Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For deno runtime load -s value as local file if non-http #2166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

For deno runtime load -s value as local file if non-http #2166

wants to merge 1 commit into from

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Oct 17, 2024

From #1930

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.61%. Comparing base (35306a2) to head (e95a5eb).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
bids-validator/src/setup/loadSchema.ts 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2166      +/-   ##
==========================================
+ Coverage   85.73%   87.61%   +1.88%     
==========================================
  Files          91      133      +42     
  Lines        3785     7172    +3387     
  Branches     1220     1702     +482     
==========================================
+ Hits         3245     6284    +3039     
- Misses        454      793     +339     
- Partials       86       95       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator

Hmm. I'm actually able to load the schema with file://$HOME/Projects/bids/specification/src/schema.json before, but not now. I'm okay with not using file:///, and this works with that. Did you test with file:///?

@effigies
Copy link
Collaborator 

❯ deno
Deno 2.0.3
exit using ctrl+d, ctrl+c, or close()
REPL is running with all permissions allowed.
To specify permissions, run `deno repl` with allow flags.
> fetch('file:///home/chris/Projects/bids/specification/src/schema.json')
Promise {
  Response {
    body: ReadableStream { locked: false },
    bodyUsed: false,
    headers: Headers {},
    ok: true,
    redirected: false,
    status: 200,
    statusText: "OK",
    url: "file:///home/chris/Projects/bids/specification/src/schema.json"
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwblair @effigies